[cfe-commits] r140232 - /cfe/trunk/lib/Sema/SemaExpr.cpp

Douglas Gregor dgregor at apple.com
Wed Sep 21 17:42:24 PDT 2011


Go for it!

Sent from my iPhone

On Sep 21, 2011, at 12:42 PM, David Blaikie <dblaikie at gmail.com> wrote:

> I'm about to send out a patch to that effect. If someone (Doug, John, etc) wants to just say "yes" when they see that, I'll check it in.
> 
> On Wed, Sep 21, 2011 at 12:31 PM, Richard Trieu <rtrieu at google.com> wrote:
> On Wed, Sep 21, 2011 at 7:11 AM, Douglas Gregor <dgregor at apple.com> wrote:
> >
> > On Sep 20, 2011, at 7:50 PM, Richard Trieu wrote:
> >
> >> Author: rtrieu
> >> Date: Tue Sep 20 21:50:14 2011
> >> New Revision: 140232
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=140232&view=rev
> >> Log:
> >> Change:
> >>
> >>  assert(!"error message");
> >>
> >> To:
> >>
> >>  assert(0 && "error message");
> >>
> >> which is more consistant across the code base.
> >>
> >> Modified:
> >>    cfe/trunk/lib/Sema/SemaExpr.cpp
> >>
> >> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
> >> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=140232&r1=140231&r2=140232&view=diff
> >> ==============================================================================
> >> --- cfe/trunk/lib/Sema/SemaExpr.cpp (original)
> >> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Tue Sep 20 21:50:14 2011
> >> @@ -8936,7 +8936,7 @@
> >>   else if (pw == Context.getTargetInfo().getLongLongWidth())
> >>     Ty = Context.LongLongTy;
> >>   else {
> >> -    assert(!"I don't know size of pointer!");
> >> +    assert(0 && "I don't know size of pointer!");
> >>     Ty = Context.IntTy;
> >
> > Just use llvm_unreachable?
> >
> >        - Doug
> >
> >
> 
> Should all assert(0 && "error") be switched to llvm_unreachable("error") ?
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110921/41a95153/attachment.html>


More information about the cfe-commits mailing list