[cfe-commits] [PATCH] Add PNaCl ABIInfo

[Eli Friedman]

On Tue, Sep 20, 2011 at 10:09 AM, David Meyer <pdox at google.com> wrote:
> Ping! Anybody available to review?

I'm not really sure the ABIArgInfo::Abstract stuff is really
appropriate, in that it is likely to generate low-quality code as-is.
I was sort of waiting for a resolution to that discussion on cfe-dev.

I don't see any issues with the patch otherwise, though.

+      if (!DestPtr) {
+         DestPtr = CreateMemTemp(RetTy, "agg.tmp");
+      }

Nit: LLVM style is no braces here.

-Eli