[cfe-commits] exclusive locks required at function boundaries

Chandler Carruth chandlerc at google.com
Wed Sep 14 18:24:54 PDT 2011


On Wed, Sep 14, 2011 at 1:24 PM, Caitlin Sadowski <supertri at google.com>wrote:

> Chandler,
>
> If you could review the first two patches, I would like to submit them
> today, if possible.
>

Sorry for delays. First three are reviewed. I think only significant changes
needed in the third. Will review the fourth when you have a cleaned up
patch... i tried to review it as-is, but couldn't get through the weird
whitespace and other random formatting changes.


>
> > Here is a first patch that refactors how errors are reported for
> > situations where there is inconisitency between locks:
> > http://codereview.appspot.com/4964080
> >
> > Building off of that, here is a patch that deals with locks required
> > attributes at function boundaries:
> > http://codereview.appspot.com/4995046
>
> Note: the fourth patch has a bunch of erroneous whitespace changes
> (IDE fail). I will send out a replacement shortly.
>
> Cheers,
>
> Caitlin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110914/ec7085da/attachment.html>


More information about the cfe-commits mailing list