[cfe-commits] r139551 - /cfe/trunk/include/clang/Driver/Options.td

Joerg Sonnenberger joerg at britannica.bec.de
Tue Sep 13 03:43:36 PDT 2011


On Mon, Sep 12, 2011 at 10:43:01PM -0000, Chad Rosier wrote:
> Author: mcrosier
> Date: Mon Sep 12 17:43:01 2011
> New Revision: 139551
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=139551&view=rev
> Log:
> [driver] Ignore the '--' option, rather then fail. Do so to match gcc's 
> behavior.
> rdar://10110352 and PR10908

I don't think this is a good idea. It violates POLA. Proper behavior
would at the very least ignore it silently. I'd suggest to start by
reverting this and committing some like the attached patch. It still
doesn't handle input file names starting with - (e.g. -c.c) correctly,
but that's a question of passing down the input correctly to internal
tools.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: handling-dashdash.diff
Type: text/x-diff
Size: 701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110913/d55d2bdc/attachment.diff>


More information about the cfe-commits mailing list