[cfe-commits] r139368 - in /cfe/trunk: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/AnalysisBasedWarnings.cpp test/SemaCXX/warn-thread-safety-analysis.cpp

[Caitlin Sadowski]

Here is patch that goes back to the old separate diagnostics.

Cheers,

Caitlin

On Fri, Sep 9, 2011 at 9:13 AM, Chandler Carruth <chandlerc at google.com> wrote:
> On Fri, Sep 9, 2011 at 9:07 AM, Caitlin Sadowski <supertri at google.com>
> wrote:
>>
>> +    // FIXME: It would be nice if this case printed without single quotes
>> around
>> +    // the phrase 'any mutex'
>
> I think you should use two diagnostics, or use a %select in the message. The
> C++ code shouldn't be providing "any mutex", all the text should come from
> the diagnostic message table.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: threadsafety_guardedvar.patch
Type: text/x-patch
Size: 5670 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110912/7b736f42/attachment.bin>