[cfe-commits] r139367 - /cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp

[Caitlin Sadowski]

>> +using namespace thread_safety;
>
> Is this necessary? I would generally prefer not to have a proliferation of
> using namespace declarations. This namespace in particular seems not
> unlikely to have names that collide with others in use in this file (that
> is, other namespaces within Analysis).

Note this is an intermediate patch. This line is no longer in
AnalysisBasedWarnings.cpp

>> +namespace clang { namespace thread_safety {
>
> This seems a bit unconventional. I would just use two lines.

Patch committed.

Cheers,

Caitlin