[cfe-commits] r139423 - in /cfe/trunk: include/clang/Basic/ lib/CodeGen/ lib/Sema/ test/CodeGen/ test/Sema/

[Julien Lerouge]

On Sat, Sep 10, 2011 at 12:13:16AM -0400, Francois Pichet wrote:
> 2 problems with this patch on Windows
> 
> On Fri, Sep 9, 2011 at 6:41 PM, Julien Lerouge <jlerouge at apple.com> wrote:
> > Author: jlerouge
> > Date: Fri Sep  9 17:41:49 2011
> > New Revision: 139423
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=139423&view=rev
> > Log:
> > Bring llvm.annotation* intrinsics support back to where it was in llvm-gcc: can
> > annotate global, local variables, struct fields, or arbitrary statements (using
> > the __builtin_annotation), rdar://8037476.
> >
> > --- cfe/trunk/test/CodeGen/2007-06-15-AnnotateAttribute.c (original)
> > +++ cfe/trunk/test/CodeGen/2007-06-15-AnnotateAttribute.c Fri Sep  9 17:41:49 2011
> > @@ -1,7 +1,6 @@
> >  // RUN: %clang_cc1 -emit-llvm %s -o - | grep llvm.global.annotations
> >  // RUN: %clang_cc1 -emit-llvm %s -o - | grep llvm.var.annotation | count 3
> >
> > -// XFAIL: *
> >  #include <stdio.h>
> 
> You shouldn't include <stdio.h>. test should be able to run in a
> freestanding environment.
> On Windows that fails because -fms-extensions is not used.

Right, I have no idea why that test was including stdio in the first
place, I removed it.

> 
> also this fails:
> 2>      Clang :: CodeGen/annotations-var.c
> 
> here is the log:
> 
> 
> 2>  Command 3 Stderr:
> 2>  C:\dev\llvm\llvm_trunk\tools\clang\test\CodeGen\annotations-var.c:21:11:
> error: expected string not found in input
> 2>  // PARAM: bitcast i32* %v.addr to i8*
> 2>            ^
> 2>  <stdin>:14:16: note: scanning from here
> 2>  define i32 @foo(i32 %v) nounwind {
> 2>                 ^
> 2>  <stdin>:17:7: note: possible intended match here
> 2>   %2 = bitcast i32* %1 to i8*

Thanks, John already fixed those I think, I completely forgot that when
building with NDEBUG set, all the names were removed. Sorry for the
breakage. Let me know if there is anything else.

Thanks,
Julien

-- 
Julien Lerouge
PGP Key Id: 0xB1964A62
PGP Fingerprint: 392D 4BAD DB8B CE7F 4E5F FA3C 62DB 4AA7 B196 4A62
PGP Public Key from: keyserver.pgp.com