[cfe-commits] Threadsafety-- basic lockset implementation

Caitlin Sadowski supertri at google.com
Wed Sep 7 12:58:10 PDT 2011

Ted (and whoever else is interested),

Here is a patch that moves the analysis to a separate file and
decouples the error reporting code. Let me know if this is what you
had in mind.

This patch is also available for review at:

In this review, the moved code is also left in
AnalysisBasedWarnings.cpp so as to make it easier to see what I have
changed along with the physical move:



On Tue, Aug 23, 2011 at 4:46 PM, Ted Kremenek <kremenek at apple.com> wrote:
> On Aug 23, 2011, at 4:31 PM, Caitlin Sadowski wrote:
> This checker is also getting pretty big.  Generally speaking
> AnalysisBasedWarnings.cpp should only contain the "top-level" logic for
> driving analyses.  The analyses themselves should be in a separate file and
> activated via a small API.  When you get a chance, please move the bulk of
> the logic to libAnalysis, and have AnalysisBasedWarnings.cpp just call the
> entry point.
> Ok, sounds good! I will do this soon.
> Thanks so much!
> The silver lining of moving it to libAnalysis is that it cleanly decouples
> the policy of issuing warnings from the analysis itself.  That allows the
> analysis to be (potentially) reused in different contexts.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: threadsafety_separatefile.patch
Type: text/x-patch
Size: 76207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110907/44cfadec/attachment.bin>

More information about the cfe-commits mailing list