[cfe-commits] [patch] Fix assertion with -Wmissing-noreturn in Obj-C method.

Joerg Sonnenberger joerg at britannica.bec.de
Wed Sep 7 06:15:57 PDT 2011


On Wed, Sep 07, 2011 at 02:12:27PM +0200, Jean-Daniel Dupas wrote:
> commit r138854 (Improve the diagnostic text for -Wmissing-noreturn to include the name of the function) does not handle Obj-C method case, and cause clang to assert when trying to emit the diagnostic due to a missing diagnostic argument.
> 
> This patch add Obj-C method handling (and update the diagnostic output to use either "function" or "method" accordingly).

Personally I would prefer two different warnings to make it easier to
search for them. Otherwise this looks good.

Joerg



More information about the cfe-commits mailing list