[cfe-commits] r139132 - in /cfe/trunk/test: FixIt/fixit-cxx0x.cpp FixIt/fixit-errors.c FixIt/fixit-function-call.cpp FixIt/fixit-missing-method-return-type.m FixIt/fixit-objc-message.m FixIt/fixit-static-object-decl.m FixIt/fixit.c FixIt/fixit.cpp Sema/format-strings-fixit.c

Richard Smith richard-llvm at metafoo.co.uk
Mon Sep 5 20:01:15 PDT 2011


Author: rsmith
Date: Mon Sep  5 22:01:15 2011
New Revision: 139132

URL: http://llvm.org/viewvc/llvm-project?rev=139132&view=rev
Log:
PR10867: Work around a bug in lit. Multiple RUN: lines are joined with &&, so:

  RUN: foo
  RUN: bar || true

is equivalent to:

  RUN: foo && bar || true

which is equivalent to:

  RUN: (foo && bar) || true

This resulted in several of the fixit tests not really testing anything.


Modified:
    cfe/trunk/test/FixIt/fixit-cxx0x.cpp
    cfe/trunk/test/FixIt/fixit-errors.c
    cfe/trunk/test/FixIt/fixit-function-call.cpp
    cfe/trunk/test/FixIt/fixit-missing-method-return-type.m
    cfe/trunk/test/FixIt/fixit-objc-message.m
    cfe/trunk/test/FixIt/fixit-static-object-decl.m
    cfe/trunk/test/FixIt/fixit.c
    cfe/trunk/test/FixIt/fixit.cpp
    cfe/trunk/test/Sema/format-strings-fixit.c

Modified: cfe/trunk/test/FixIt/fixit-cxx0x.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-cxx0x.cpp?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-cxx0x.cpp (original)
+++ cfe/trunk/test/FixIt/fixit-cxx0x.cpp Mon Sep  5 22:01:15 2011
@@ -1,6 +1,6 @@
 // RUN: %clang_cc1 -verify -std=c++0x %s
 // RUN: cp %s %t
-// RUN: %clang_cc1 -x c++ -std=c++0x -fixit %t || true
+// RUN: not %clang_cc1 -x c++ -std=c++0x -fixit %t
 // RUN: %clang_cc1 -Wall -pedantic -x c++ -std=c++0x %t
 
 /* This is a test of the various code modification hints that only

Modified: cfe/trunk/test/FixIt/fixit-errors.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-errors.c?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-errors.c (original)
+++ cfe/trunk/test/FixIt/fixit-errors.c Mon Sep  5 22:01:15 2011
@@ -1,5 +1,5 @@
 // RUN: cp %s %t
-// RUN: true || %clang_cc1 -pedantic -verify -fixit -x c %t
+// RUN: %clang_cc1 -pedantic -verify -fixit -x c %t
 // RUN: %clang_cc1 -pedantic -Werror -x c %t
 // XFAIL: *
 

Modified: cfe/trunk/test/FixIt/fixit-function-call.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-function-call.cpp?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-function-call.cpp (original)
+++ cfe/trunk/test/FixIt/fixit-function-call.cpp Mon Sep  5 22:01:15 2011
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 -fdiagnostics-parseable-fixits -x c++ %s 2> %t  || true
+// RUN: not %clang_cc1 -fdiagnostics-parseable-fixits -x c++ %s 2> %t
 // RUN: FileCheck %s < %t
 // PR5941
 // END.

Modified: cfe/trunk/test/FixIt/fixit-missing-method-return-type.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-missing-method-return-type.m?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-missing-method-return-type.m (original)
+++ cfe/trunk/test/FixIt/fixit-missing-method-return-type.m Mon Sep  5 22:01:15 2011
@@ -1,11 +1,11 @@
 // Objective-C recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -Wmissing-method-return-type -fixit -x objective-c %t || true
+// RUN: %clang_cc1 -Wmissing-method-return-type -fixit -x objective-c %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wmissing-method-return-type -Werror -x objective-c %t
 
 // Objective-C++ recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -Wmissing-method-return-type -fixit -x objective-c++ %t || true
+// RUN: %clang_cc1 -Wmissing-method-return-type -fixit -x objective-c++ %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wmissing-method-return-type -Werror -x objective-c++ %t
 // rdar://9615045
 

Modified: cfe/trunk/test/FixIt/fixit-objc-message.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-objc-message.m?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-objc-message.m (original)
+++ cfe/trunk/test/FixIt/fixit-objc-message.m Mon Sep  5 22:01:15 2011
@@ -1,11 +1,11 @@
 // Objective-C recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -pedantic -Wall -fixit -x objective-c %t || true
+// RUN: not %clang_cc1 -pedantic -Wall -fixit -x objective-c %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Werror -x objective-c %t
 
 // Objective-C++ recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -pedantic -Wall -fixit -x objective-c++ %t || true
+// RUN: not %clang_cc1 -pedantic -Wall -fixit -x objective-c++ %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Werror -x objective-c++ %t
 
 @interface A

Modified: cfe/trunk/test/FixIt/fixit-static-object-decl.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit-static-object-decl.m?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit-static-object-decl.m (original)
+++ cfe/trunk/test/FixIt/fixit-static-object-decl.m Mon Sep  5 22:01:15 2011
@@ -1,11 +1,11 @@
 // Objective-C recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -fixit -x objective-c %t || true
+// RUN: not %clang_cc1 -fixit -x objective-c %t
 // RUN: %clang_cc1 -fsyntax-only -Werror -x objective-c %t
 
 // Objective-C++ recovery
 // RUN: cp %s %t
-// RUN: %clang_cc1 -fixit -x objective-c++ %t || true
+// RUN: not %clang_cc1 -fixit -x objective-c++ %t
 // RUN: %clang_cc1 -fsyntax-only -Werror -x objective-c++ %t
 // rdar://9603056
 

Modified: cfe/trunk/test/FixIt/fixit.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit.c?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit.c (original)
+++ cfe/trunk/test/FixIt/fixit.c Mon Sep  5 22:01:15 2011
@@ -1,5 +1,5 @@
 // RUN: cp %s %t
-// RUN: %clang_cc1 -pedantic -Wunused-label -fixit -x c %t || true
+// RUN: not %clang_cc1 -pedantic -Wunused-label -fixit -x c %t
 // RUN: grep -v CHECK %t > %t2
 // RUN: %clang_cc1 -pedantic -Wunused-label -Werror -x c %t
 // RUN: FileCheck -input-file=%t2 %t

Modified: cfe/trunk/test/FixIt/fixit.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/FixIt/fixit.cpp?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/FixIt/fixit.cpp (original)
+++ cfe/trunk/test/FixIt/fixit.cpp Mon Sep  5 22:01:15 2011
@@ -1,5 +1,5 @@
 // RUN: cp %s %t
-// RUN: %clang_cc1 -pedantic -Wall -fixit -x c++ %t || true
+// RUN: not %clang_cc1 -pedantic -Wall -fixit -x c++ %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Werror -x c++ %t
 
 /* This is a test of the various code modification hints that are

Modified: cfe/trunk/test/Sema/format-strings-fixit.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/format-strings-fixit.c?rev=139132&r1=139131&r2=139132&view=diff
==============================================================================
--- cfe/trunk/test/Sema/format-strings-fixit.c (original)
+++ cfe/trunk/test/Sema/format-strings-fixit.c Mon Sep  5 22:01:15 2011
@@ -1,5 +1,5 @@
 // RUN: cp %s %t
-// RUN: %clang_cc1 -pedantic -Wall -fixit %t || true
+// RUN: %clang_cc1 -pedantic -Wall -fixit %t
 // RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Werror %t
 // RUN: %clang_cc1 -E -o - %t | FileCheck %s
 





More information about the cfe-commits mailing list