[cfe-commits] r139112 - /cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Chandler Carruth chandlerc at gmail.com
Sun Sep 4 22:47:35 PDT 2011


Author: chandlerc
Date: Mon Sep  5 00:47:35 2011
New Revision: 139112

URL: http://llvm.org/viewvc/llvm-project?rev=139112&view=rev
Log:
Enable -Wdangling-fields by default in Clang. I've run this warning over
a very large chunk of code and found zero false positives. I've only
found a few bugs, but that likely is because bugs of this nature
actually do manifest. We've also identified several bugs that were
caught by Valgrind, but would have been caught faster and more easily
with this warning.

If anyone has concerns, or this causes fallout on any build bots, lemme
know. I'm happy to just put it under -Wmost.

Modified:
    cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=139112&r1=139111&r2=139112&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)
+++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Mon Sep  5 00:47:35 2011
@@ -4358,13 +4358,13 @@
 // a constructor parameter.
 def warn_bind_ref_member_to_parameter : Warning<
   "binding reference member %0 to stack allocated parameter %1">,
-  InGroup<DiagGroup<"dangling-field">>, DefaultIgnore;
+  InGroup<DiagGroup<"dangling-field">>;
 def warn_init_ptr_member_to_parameter_addr : Warning<
   "initializing pointer member %0 with the stack address of parameter %1">,
-  InGroup<DiagGroup<"dangling-field">>, DefaultIgnore;
+  InGroup<DiagGroup<"dangling-field">>;
 def warn_bind_ref_member_to_temporary : Warning<
   "binding reference member %0 to a temporary value">,
-  InGroup<DiagGroup<"dangling-field">>, DefaultIgnore;
+  InGroup<DiagGroup<"dangling-field">>;
 def note_ref_or_ptr_member_declared_here : Note<
   "%select{reference|pointer}0 member declared here">;
 





More information about the cfe-commits mailing list