[cfe-commits] [PATCH]Clang/PNaCl: add checks for alignment of basic datatypes. Fix nits.

Eli Friedman eli.friedman at gmail.com
Mon Aug 29 14:29:27 PDT 2011

On Mon, Aug 29, 2011 at 2:05 PM, Ivan Krasin <krasin at chromium.org> wrote:
> Hi Clang team!
> This CL improves test coverage for PNaClTargetInfo. I have found a way
> (well, stolen it from other part of nacl codebase) to test the
> alignments with FileCheck, so adding checks for the alignment of basic
> datatypes.
> Also it fixes two nits: wrong alignment for double (it was 4, but 8 is
> desired) and added checks for _REENTRANT define.
> The patch is attached and is also available online:
> http://codereview.chromium.org/7794004/
> Please, let me know if it's fine to commit.

Looks fine.


More information about the cfe-commits mailing list