[cfe-commits] [patch] warn on missing [super finalize] call

Nico Weber thakis at chromium.org
Sun Aug 28 02:58:24 PDT 2011


Hi,

the attached patch makes clang warn on missing [super finalize] calls.
The warning uses the same logic as gcc (
http://codesearch.google.com/#N01oSP8jpDo/gcc/objc/objc-act.c , search
for "should_call_super_finalize" in that file). This is half of
PR10661.

This follows Fariborz' advice from
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20110822/045443.html
. I added OMF_finalize to a few switch statements, mostly to fix
"unhandled value in switch" warnings – I tried to add it so that it
didn't change the previous semantics.

Ok?

Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-missing-finalize.patch
Type: application/octet-stream
Size: 8725 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110828/81bc316c/attachment.obj>


More information about the cfe-commits mailing list