[cfe-commits] [PATCH] Handle CXXTempObjectRegion in StackAddrEscapeChecker

[Ted Kremenek]

On Aug 25, 2011, at 5:05 PM, Jeffrey Yasskin wrote:

> Hi Ted,
> 
> Here's a patch that adds support for CXXTempObjectRegions in
> StackAddrEscapeChecker.

Patch looks great!

> I changed stack-addr-ps.cpp to exercise it,
> but to do that I had to extract the -fblocks test into a different
> file since a single error seems to prevent the analysis from running.

That's fine.  Thanks for doing this.

> 
> Running the analyzer appears to duplicate warnings that are produced
> by Sema too. This is annoying, but since stack-addr-ps.c includes the
> duplicate warnings, I assume that's expected.

It's expected.  The analyzer should be viewed as a separate tool from the compiler.  In a real workflow, it's results are presented separately from the compiler results (e.g., with scan-build or within an IDE).  We only have the static analyzer diagnostics printed out in this way for testing.  It's actually nice that both the compiler warning and analyzer warnings are there; it allows us to cross-check them.