[cfe-commits] [PATCH]Add PNaCl TargetInfo to Clang

[Eric Christopher]

On Aug 24, 2011, at 1:07 PM, Ivan Krasin wrote:

> On Wed, Aug 24, 2011 at 12:51 PM, Eric Christopher <echristo at apple.com> wrote:
>> 
>> On Aug 24, 2011, at 12:36 PM, Ivan Krasin wrote:
>> 
>>> Hi Eric,
>>> 
>>> Please, find the updated patch attached or
>>> http://codereview.chromium.org/7717004/
>>> 
>>> 1. I've updated RUN: lines as suggested. Now, it does not create temp files
>> 
>> Yeah, we try to avoid grep if at all possible :)
> Done.
> 

Yeah, some of the testers have grep programs that drive valgrind nuts. It's annoying :)

>> 
>>> 2. I've fixed __builtin_va_list definition and added a test for that
>>> (unrelated catch)
>> 
>> Looks good. Thanks!
>> 
>> -eric
>> 
> <pnacl_target_no_grep.patch>


OK.

Thanks!

-eric