[cfe-commits] BCPL comments not recognized when computing preamble

Argyrios Kyrtzidis kyrtzidis at apple.com
Wed Aug 24 10:17:02 PDT 2011


On Aug 24, 2011, at 9:21 AM, Matthias Kleine wrote:

> Is there any reason Lexer::ComputePreamble does not take external LangOptions into account, but uses default-constructed ones? As a result, source files that start with BCPL-comments are recognized as having no preambles, even if the file's language supports such comments.
> 
> Would the attached patch solve the problem?

Look good, could you also please add a test case as well ?

> 
> Cheers,
> Matthias<pass_lang_options_to_compute_preamble.patch>_______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list