[cfe-commits] [PATCH] Add fixit notes for -Wconstant-logical-operand

[Sean Hunt]

On Fri, Aug 12, 2011 at 16:27, Matt Beaumont-Gay <matthewbg at google.com>wrote:

> I implemented these for purely selfish reasons, viz., I want to apply
> them en masse to some hilariously broken code. What I feel might be
> missing is a way to just silence the warning, though I'm not sure how
> useful that would be.
>
> Also, my impression is that the prevailing style in diagnostic text is
> to surround operators in single quotes, so I've changed the warning to
> match; any objections?
>
> -Matt


My only comment is on the note text, perhaps "bitwise '%0' could be used
instead"?

Other than that, looks good to me.

Sean
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110814/6c9c22ee/attachment.html>