[cfe-commits] r137298 - in /cfe/trunk: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/Lexer.h include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Lex/TokenConcatenation.cpp test/CodeGen/string-literal.c test/Lexer/cxx0x_raw_string_delim_length.cpp test/Lexer/cxx0x_raw_string_unterminated.cpp test/SemaCXX/cxx0x-type-convert-construct.cpp

[Chris Lattner]

On Aug 10, 2011, at 9:06 PM, Craig Topper wrote:

> Author: ctopper
> Date: Wed Aug 10 23:06:15 2011
> New Revision: 137298
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=137298&view=rev
> Log:
> Add support for C++0x raw string literals.

Thanks Craig,

> +++ cfe/trunk/include/clang/Lex/LiteralSupport.h Wed Aug 10 23:06:15 2011
> @@ -197,6 +197,7 @@
> 
> private:
>   void init(const Token *StringToks, unsigned NumStringToks);
> +  void CopyStringFragment(const StringRef &Fragment);

Sorry to nit-pick, but please pass StringRef by value.

> +/// IsStringPrefix - Return true if Str is a string prefix.
> +/// 'L', 'u', 'U', or 'u8'. Including raw versions.
> +static bool IsStringPrefix(const StringRef &Str, bool CPlusPlus0x) {

Likewise.

-Chris