[cfe-commits] [PATCH] Implement va_arg alignment in clang on ARM

Renato Golin renato.golin at arm.com
Tue Aug 2 13:59:34 PDT 2011


2011/8/2 Rafael Ávila de Espíndola <rafael.espindola at gmail.com>:
>> This patch implements alignment for long long types in va_arg on ARM AAPCS.
>> Without alignment, sqlite breaks on ARM because it uses 64-bit types extensively in vaarg calls (printf).
>
> I think this is fine.  Renato, can you confirm?

Hi Rafael,

Sorry for the delay.

I haven't found anything specifically related to va_arg and long long,
but variadic routines follow the base standard, and on the base
standard, both long long and double align to 8 bytes.

I think you're safe (until proven otherwise) ;)

--renato




More information about the cfe-commits mailing list