[cfe-commits] r135577 - in /cfe/trunk: include/clang/AST/ include/clang/Analysis/ include/clang/Analysis/Analyses/ include/clang/Basic/ include/clang/CodeGen/ include/clang/Driver/ include/clang/Frontend/ include/clang/Index/ include/clang/Parse/

[Mulder, Jonathan]

Hi Chris,

Please find the attached that cleans up the places that I found from greping
through the source. Note that I just finished up things that I found in
header files as you said you were going to go through the .cpp files. I
built with Release+Asserts after making these changes and ran the test suite
without issue.

FYI, I'm going to move onto ArrayRef next and will clean things up in the
cpp files as I go through if I notice anything.

Thanks,
Jon

On Fri, Jul 22, 2011 at 3:31 PM, Chris Lattner <clattner at apple.com> wrote:

>
> On Jul 22, 2011, at 11:58 AM, Mulder, Jonathan wrote:
>
> > Hi Chris,
> >
> > This may be a silly question, but is there a reason why these changes
> were restricted to the header files? Or is it just that you haven't gotten
> around to making the changes in the .cpp files?
>
> Um, that looks like a 'find' failure. I certainly intended .cpp files to be
> changed as well, I'll take care of that.
>
> > Also, I notice that there are still some forward declarations of
> raw_ostream in some header files, for instance
> "include/clang/AST/PrettyPrinter.h". Are these left as in-file forward
> declarations versus including "LLVM.h" because the utility of leaving the
> forward declaration in-file and tying out the using statement versus
> including "LLVM.h" isn't sufficient for being able to change one case of
> "llvm::raw_stream" to "raw_ostream" in the header file? Or is this - like
> the last question - just a case of not having gotten here yet? Or have I
> just completely missed the boat here? :)
>
> These I missed, if you'd like to tackle them, I'd appreciate it!  Thanks,
>
> -Chris
>
>


-- 
Jon Mulder
C 847.899.3664
E mulderje at muohio.edu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/d3d59d23/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: raw_ostream_SmallVecImpl.patch
Type: application/octet-stream
Size: 6351 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110722/d3d59d23/attachment.obj>