[cfe-commits] [PATCH] Define DiagnosticBuilder<<APValue (issue4749047)

[Jeffrey Yasskin]

On Sun, Jul 17, 2011 at 5:49 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Jul 17, 2011, at 2:41 PM, jyasskin at gmail.com wrote:
>
>> Reviewers: cfe-commits_cs.uiuc.edu,
>>
>> Message:
>> Initial diff at
>> http://codereview.appspot.com/download/issue4749047_1.diff.
>>
>> I haven't tested the makefile yet.
>>
>> Description:
>> Define DiagnosticBuilder<<APValue so it's easy to include APValues in
>> diagnostics.  This is likely to get more important as generalized
>> constant expressions get implemented.
>
> Please send patches to the list, not links to an external review site.

Whoops, sorry, I mis-remembered the right way to do this.

> Why is WriteShortAPValueToStream templated?  Please convert it to always take a raw_ostream and handle the builder case outside the recursive call.

Done.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: apvalue_diag.diff
Type: application/octet-stream
Size: 7305 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110718/6fa6027c/attachment.obj>