[cfe-commits] [Patch] Remove checking signs of operands of conditional operator from -Wsign-compare

Richard Trieu rtrieu at google.com
Fri Jul 15 14:31:21 PDT 2011


Patch to completely remove warning for mixed signedness of conditional
operands.

Still available at http://codereview.appspot.com/4731042/

On Thu, Jul 14, 2011 at 4:30 PM, Chandler Carruth <chandlerc at google.com>wrote:

> On Thu, Jul 14, 2011 at 4:24 PM, Richard Trieu <rtrieu at google.com> wrote:
>
>> The main motivation is to make -Wsign-compare only about checking signs
>> during comparisons.  Since the operands of the conditional operator aren't
>> compared, it seems out of place to check it there.
>
>
> So, howabout a patch to just remove this part of -Wsign-compare? I mean, if
> there is a good reason to keep it, then cool, I just don't think we need
> another warning here...
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110715/4e34d422/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mixed-sign-conditional-removal.patch
Type: text/x-patch
Size: 16524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110715/4e34d422/attachment.bin>


More information about the cfe-commits mailing list