[cfe-commits] r134587 - in /cfe/trunk: include/clang/Basic/SourceManager.h include/clang/Lex/MacroInfo.h include/clang/Lex/TokenLexer.h lib/ARCMigrate/TransformActions.cpp lib/ARCMigrate/Transforms.cpp lib/Basic/SourceManager.cpp lib/Lex/Lexer.cpp lib/Lex/MacroArgs.cpp lib/Lex/MacroArgs.h lib/Lex/MacroInfo.cpp lib/Lex/TokenLexer.cpp lib/Parse/ParseExpr.cpp test/PCH/variables.c test/PCH/variables.h test/Parser/recovery.c

[Argyrios Kyrtzidis]

On Jul 6, 2011, at 9:18 PM, Sean Hunt wrote:

> On 07/06/11 20:40, Argyrios Kyrtzidis wrote:
>> Modified: cfe/trunk/lib/Basic/SourceManager.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/SourceManager.cpp?rev=134587&r1=134586&r2=134587&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Basic/SourceManager.cpp (original)
>> +++ cfe/trunk/lib/Basic/SourceManager.cpp Wed Jul  6 22:40:34 2011
>> @@ -11,6 +11,7 @@
>>  //
>>  //===----------------------------------------------------------------------===//
>> 
>> +#include "clang/Lex/Lexer.h"
> 
> This creates a layering violation; Lex can't depend on Basic.

I think you meant it the other way but point taken, thanks for reviewing!

> 
> Sean