[cfe-commits] [PATCH] StringRef'ize clang::driver::Option::getName()
clattner at apple.com
Thu Jun 30 13:04:47 PDT 2011
On Jun 30, 2011, at 11:47 AM, Zach Wheeler wrote:
> This patch changes the return type of Option::getName() from const char* to StringRef, doing away with the need for several calls to strlen.
> Clang builds fine with these changes.
THis patch looks reasonable, except that it completely breaks the testsuite :). Please track down the bug and resubmit a patch. Also, why not just embed a 'Name' StringRef in Option.h instead of storing the start+size?
More information about the cfe-commits