[cfe-commits] [PATCHES] don't include config.h in public headers

Eric Christopher echristo at apple.com
Wed Jun 22 10:53:33 PDT 2011

On Jun 22, 2011, at 5:18 AM, nobled wrote:

> llvm/Config/config.h contains a lot of standard macros like
> PACKAGE_VERSION that don't make sense to expose to clients, who will
> probably have their own private config.h with its own definition of
> PACKAGE_VERSION et al. Right now, Klee runs into this and seems to be
> working around it with #undef[1].
> It's not actually needed in most cases, and these four patches remove
> all the uses in llvm and clang headers. Unless it's also being
> included in dragonegg or lldb sources or something, the file can
> probably be excluded from `make install` entirely after this (but I'm
> not sure how to do that). Okay to commit?

Looks good to me.



More information about the cfe-commits mailing list