[cfe-commits] PATCH: Add support for C++ namespace-aware typo correcting

Kaelyn Uhrain rikka at google.com
Mon Jun 20 11:20:24 PDT 2011

Ok, so I think updating the CXXScopeSpec in CorrectTypo is beyond my current
clang-fu.  I've tried both

    if (SS && Result.getCorrectionSpecifier())


    if (SS && Result.getCorrectionSpecifier())
      SS->MakeTrivial(Context, Result.getCorrectionSpecifier(),

just before returning the TypoCorrection from CorrectTypo
@SemaLookup.cpp:3716 and both lead to a violent death; the former with a
segfault within CXXScopeSpec::Adopt and the latter with an assertion failure
about the source range in CXXScopeSpec::Extend (the same assertion is
triggered if I replace SS->getRange() with SourceRange()).  Any ideas,
suggestions, or comments?

And that isn't even touching the situations where CorrectTypo is called with
a NULL CXXScopeSpec pointer in C++ code yet.  Sigh.

- Kaelyn

On Mon, Jun 20, 2011 at 10:14 AM, Kaelyn Uhrain <rikka at google.com> wrote:

> Managed to not reply to all... which is okay as the patch was against the
> clang git tree as of a couple weeks ago and recent changes causes a couple
> of minor merge conflicts.  Here's the patch based on the current git HEAD.
> On Mon, Jun 20, 2011 at 9:54 AM, Kaelyn Uhrain <rikka at google.com> wrote:
>> Here ya go.  It has most of the smaller changes based on dgregor's most
>> recent feedback.  It also makes CorrectTypo know when argument-dependent
>> lookup is required and skips trying namespace qualifiers, which allows
>> basic.lookup.argdep/p4.cpp to pass. The main pieces I'm still working on
>> (within CorrectTypo at least) are improving the caching and updating the
>> CXXScopeSpec if/when possible.  I also still need to remove the use of
>> std::multimap, though you're welcome to benchmark it and alternatives. ;)
>> On Mon, Jun 20, 2011 at 9:37 AM, Chandler Carruth <chandlerc at google.com>wrote:
>>> On Mon, Jun 20, 2011 at 9:35 AM, Kaelyn Uhrain <rikka at google.com> wrote:
>>>> Don't quite have it ready yet.  Being sick for much of last week didn't
>>>> help...
>>>> I could post for submission my last patch + the smaller cleanups that I
>>>> already have done and finish up the work as a second patch, so that folks
>>>> can get started on the serialization, etc.
>>> I'm just looking for a WIP patch that I can run with.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110620/6e8a53f5/attachment.html>

More information about the cfe-commits mailing list