[cfe-commits] [PATCH] Refactoring of vtable and VTT builders

Anders Carlsson andersca at mac.com
Mon Jun 13 15:19:11 PDT 2011

On Jun 13, 2011, at 12:41 PM, Peter Collingbourne wrote:

> Hi,
> This patch refactors the vtable and VTT builders to provide a
> backend-neutral interface to the builders in the AST library, which
> CodeGen uses to build vtables and VTTs in LLVM.  No functionality
> change intended.

While I'm not crazy about this idea, other people (Doug) are in favor of it, so I'm reluctantly fine with it :)

That being said, I don't think this patch should be committed in its current state. This should be done in incremental steps,
there's no reason to move both the VTT builder and VTable builder in a single commit.

Also, the files should be svn cp'ed to preserve history; being able to easily go back and see the rationale behind changes is
crucial to fixing bugs/regressions in this code.

- Anders

More information about the cfe-commits mailing list