[cfe-commits] New files for libcxxabi

Howard Hinnant hhinnant at apple.com
Thu Jun 9 20:33:13 PDT 2011


On Jun 9, 2011, at 1:13 PM, Marshall Clow wrote:

> 
> On Jun 8, 2011, at 1:47 PM, John McCall wrote:
> 
>> 
>> On Jun 7, 2011, at 1:15 PM, Marshall Clow wrote:
>> 
>>> Implements the new [] and delete [] functionality.
>>> With tests.
>>> 
>>> Comments please.
>>> I'm not 100% sure that the exception handling is correct - so that's a good place to look ;-)
>> 
>> The exception handling is not correct:  you should be using cleanups instead of try/catch.  The best way to do this is with an RAII object which is explicitly disabled on the non-exception path.
> 
> 
> Here are modified files (with more tests, too!)
> 
> Comments?

Thanks Marshall.  Please commit.

Howard




More information about the cfe-commits mailing list