[cfe-commits] [libcxxabi] r132524 - in /libcxxabi/trunk: include/cxxabi.h src/cxa_aux_runtime.cpp src/cxa_virtual.cpp

[Anders Carlsson]

On Jun 2, 2011, at 7:16 PM, Douglas Gregor wrote:

> 
> On Jun 2, 2011, at 7:04 PM, Marshall Clow wrote:
> 
>> Author: marshall
>> Date: Thu Jun  2 21:04:41 2011
>> New Revision: 132524
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=132524&view=rev
>> Log:
>> Added __cxa_bad_cast and __cxa_bad_typeid and placeholder NORETURN macro
> 
> Marshall, did someone pre-approve this commit?
> 
> LIBCXXABI_NORETURN should be trivial to implement correctly, given that we have an attribute for it. Why commit a placeholder when it's easier to do the right thing?
> 
> Also, any commit needs accompanying tests.
> 
> Please revert this.
> 
> 	- Doug

Also, you're including <typeinfo> which doesn't exist yet; it should also be provided by libcxxabi.

- Anders