[cfe-commits] Patch: Warn on logical operations with constants

Chandler Carruth chandlerc at google.com
Thu May 26 03:18:08 PDT 2011

On Fri, May 6, 2011 at 1:38 PM, Richard Trieu <rtrieu at google.com> wrote:

> The old warning that checked for logical operators with constants did not
> treat 1 and 0 as it would for other constants.  Changed the warning so that
> if a bool type exists, 1 and 0 will trigger the warning.

Is there a PR for this? It'd be good to have more motivating examples in the
description or something... But you do have one in the Code Review
description I see.

> Patch is attached and available through Code Review:
> http://codereview.appspot.com/4444068/

Some minor comments left on the patch here.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110526/ebd9c72a/attachment.html>

More information about the cfe-commits mailing list