[cfe-commits] r131672 - in /cfe/trunk: lib/Lex/PPMacroExpansion.cpp test/Lexer/has_feature_type_traits.cpp

[Douglas Gregor]

On May 19, 2011, at 1:48 PM, Sean Hunt wrote:

> Author: coppro
> Date: Thu May 19 15:48:13 2011
> New Revision: 131672
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=131672&view=rev
> Log:
> Implement a __has_feature for __underlying_type
> 
> Modified:
>    cfe/trunk/lib/Lex/PPMacroExpansion.cpp
>    cfe/trunk/test/Lexer/has_feature_type_traits.cpp
> 
> Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Lex/PPMacroExpansion.cpp?rev=131672&r1=131671&r2=131672&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Lex/PPMacroExpansion.cpp (original)
> +++ cfe/trunk/lib/Lex/PPMacroExpansion.cpp Thu May 19 15:48:13 2011
> @@ -602,6 +602,7 @@
>            .Case("is_trivial", LangOpts.CPlusPlus)
>            .Case("is_trivially_copyable", LangOpts.CPlusPlus)
>            .Case("is_union", LangOpts.CPlusPlus)
> +           .Case("underlying_type", LangOpts.CPlusPlus)
>            .Case("tls", PP.getTargetInfo().isTLSSupported())
>            .Default(false);
> }

Please revert this change! The implementation of __underlying_type is nowhere near complete, so we must not advertise this feature.

	- Doug