[cfe-commits] r131373 - in /cfe/trunk/lib/CodeGen: CGBlocks.cpp CGObjC.cpp CGObjCMac.cpp CodeGenModule.cpp CodeGenModule.h

John McCall rjmccall at apple.com
Sat May 14 21:40:36 PDT 2011


On May 14, 2011, at 9:39 PM, Chris Lattner wrote:
> On May 14, 2011, at 6:53 PM, John McCall wrote:
>> Author: rjmccall
>> Date: Sat May 14 20:53:33 2011
>> New Revision: 131373
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=131373&view=rev
>> Log:
>> Use arrays and SmallVectors instead of std::vectors when building function
>> types.  Also, cache a translation of 'void' in CGM and provide a ptrdiff_t
>> alias.  No functionality change.
> 
> I don't know if it makes sense in this case, but instead of passing a SmallVectorImpl<x>, consider passing an ArrayRef<x>

I believe all of these cases are mutable.  I do know about ArrayRef. :)

John.



More information about the cfe-commits mailing list