[cfe-commits] TranslationUnit check position support

[Ted Kremenek]

One other thing I noticed in the patch:

  (const Decl* D, AnalysisManager &mgr, ...)

why use a generic Decl*?  Since it is always going to be a TranslationUnitDecl*, we should pass the most specific type.

On May 3, 2011, at 10:50 AM, Argyrios Kyrtzidis wrote:

> A more appropriate name is checkEndOfTranslationUnit (a checker can already check the TranslationUnitDecl with checkASTDecl which is called at the beginning).
> 
> So please change runCheckersOnTranslationUnit -> runCheckersOnEndOfTranslationUnit and likewise for the rest of the patch ("class TranslationUnit" -> "class EndOfTranslationUnit", etc.).
> 
> Otherwise looks good!
> 
> On May 2, 2011, at 8:33 PM, 章磊 wrote:
> 
>> Hi Clang,
>> 
>> This patch add a new check position checkTranslationUnit for a check after all the decls in the translation unit analyzed, then we can do some statistical analysis in this check position.
>> 
>> This patch is preparation for statistical UncheckedRenturn checker.
>> I'll appreciate it if there are any advice about this patch.
>> 
>> -- 
>> Best regards!
>> 
>> Lei Zhang
>> <checkTranslationUnit.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits