[cfe-commits] r130642 - in /cfe/trunk: include/clang/AST/DeclCXX.h include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Initialization.h include/clang/Sema/Sema.h lib/CodeGen/CGClass.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h lib/Lex/PPMacroExpansion.cpp lib/Sema/SemaDeclCXX.cpp lib/Sema/SemaInit.cpp test/CodeGenCXX/cxx0x-delegating-ctors.cpp test/SemaCXX/cxx0x-delegating-ctors.cpp www/cxx_status.html

[Sean Hunt]

On 11-05-01 02:21 PM, John McCall wrote:
> The convention is that methods which access data which is only valid in
> certain configurations of the AST node they're on should be named to
> make that clear, and unless there's a good reason not to, they should
> assert on that to catch bugs.  Obviously those aren't universally followed,
> but more consistent is better.

Ah, ok. Sounds good then.

> You don't need to give multiple errors, but you do need the compiler
> not to hang indefinitely because (1) it keeps finding Targets but
> (2) none of them are Constructor.  My example currently hangs
> the compiler.  Please fix this.

Ooh, that's bad. Do you think it's better to track every constructor or 
just set a maximum depth (10? 100 given the cheapness of an iteration?)?

> Joh.

Sea