[cfe-commits] [PATCH] remove unused STL header includes

Jay Foad jay.foad at gmail.com
Sat Apr 23 04:02:22 PDT 2011


These patches remove unnecessary #includes of STL header files. Found
by grepping for e.g. "#include <vector>" in files that don't mention
std::vector. (And no files should be using "using namespace std",
according to the coding standards.)

Tested with "make all check-all", LLVM and Clang, on my Ubuntu system.
I suppose there is a chance that the headers on my system are a bit
more permissive than they need to be, and I've removed some #includes
that are technically still required, but that seems fairly unlikely to
me.

OK to commit?

I was inspired by:

http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20110411/119566.html

which showed that pulling in unneeded header files could have a
noticeable effect on build times.

Thanks,
Jay.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-headers.diff
Type: text/x-patch
Size: 14658 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110423/018b7988/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-headers.diff
Type: text/x-patch
Size: 6980 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110423/018b7988/attachment-0001.bin>


More information about the cfe-commits mailing list