[cfe-commits] [PATCH] Change cmp_XY x86/AVX builtin definition from static inline to macro in avxintrin.h

John McCall rjmccall at apple.com
Thu Apr 7 23:37:49 PDT 2011

On Apr 7, 2011, at 9:42 PM, Syoyo Fujita wrote:
>>> mmx-builtins.c tests asm output, but in my patch I'd like to test LLVM
>>> IR outout.
>> This is easy;  just turn the -S in the RUN line into an -emit-llvm.  That
>> will also avoid any AVX-related bugs in the backend.
>> The main thing is that there are several portability workarounds in that
>> test, like the #define, that you'll want to borrow for your test.
> Okay, I've fixed a test code. Does this looks OK? If so, I'll submit a
> fixed test again.
> At least it works well in my local ToT on Mac.
> 1) Replace -S with -emit-llvm
> 2) Add #define _MM_MALLOC_H
> 3) Since this test checks if third(last) argument is constant
> expression, we don't care how other arguments are codegen'ed. Use wild
> pattern for that arguments to relax LLVM IR codegen matching.

This looks right.


More information about the cfe-commits mailing list