[cfe-commits] [PATCH] Change cmp_XY x86/AVX builtin definition from static inline to macro in avxintrin.h

Syoyo Fujita syoyofujita at gmail.com
Wed Apr 6 23:04:54 PDT 2011


Thanks John!

> For what it's worth, I've had to remove the test case because the
> intrinsics headers are too host-dependent.

Is there any good way to write a such host-dependent test in clang
test-framework?
I'm ready to write a test if a guideline is provided.

On Thu, Apr 7, 2011 at 5:53 AM, John McCall <rjmccall at apple.com> wrote:
> On Apr 5, 2011, at 8:42 PM, John McCall wrote:
>> On Mar 30, 2011, at 1:22 AM, Syoyo Fujita wrote:
>>> Chris,
>>>
>>>> Please parenthesize all macro arguments (in particular use ", (c))" instead of ", c)".  Ok with that fix, thanks!
>>>
>>> OK, attached is a modified patch. Just "c" is parenthesized.
>>
>> Committed in r128984, thanks!
>
> For what it's worth, I've had to remove the test case because the
> intrinsics headers are too host-dependent.
>
> John.
>




More information about the cfe-commits mailing list