[cfe-commits] [PATCH] review request: mempcpy() checker implementation for Static Analyzer

Lenny Maiorani lenny at Colorado.EDU
Wed Mar 30 16:34:04 PDT 2011


On 03/30/2011 05:17 PM, Ted Kremenek wrote:
> On Mar 30, 2011, at 3:52 PM, Lenny Maiorani wrote:
>
>> Ok, I will make those changes. Not sure how my emacs settings got
>> changed, but...
> Okay, great!
>
>> As for the modeling of mempcpy() (and memcpy() for that matter): the
>> behavior is that if NULL is passed as either the src or dst there will
>> be a NULL pointer dereference unless the number of bytes to copy is 0. I
>> am re-working the flow through evalCopyCommon to accurately reflect that.
> I'm fine with that coming in with a later patch.  I just didn't know what the plan was.  Please feel free to use FIXME comments in the code to indicate "things to do" in the future.
>
> If you want to regenerate the patch without tabs (and comments adjusted), I'll be happy to apply it!
I will regenerate it with the fix. :) It is small and I will probably 
submit it tomorrow.

-Lenny




More information about the cfe-commits mailing list