[cfe-commits] [PATCH] Change cmp_XY x86/AVX builtin definition from static inline to macro in avxintrin.h

[Syoyo Fujita]

Chris,

> Please parenthesize all macro arguments (in particular use ", (c))" instead of ", c)".  Ok with that fix, thanks!

OK, attached is a modified patch. Just "c" is parenthesized.

--
Syoyo

On Tue, Mar 29, 2011 at 8:11 AM, Chris Lattner <clattner at apple.com> wrote:
>
> On Mar 28, 2011, at 1:15 AM, Syoyo Fujita wrote:
>
>> Current implementation uses static inline definition for cmp_XY AVX
>> instruction.
>> With this clang cannot emit immediate value for 3rd argument where
>> immediate value is requested.
>>
>> This patch fixes the problem so that clang's codegen correctly emit
>> immediate value for 3rd argument.
>
> Please parenthesize all macro arguments (in particular use ", (c))" instead of ", c)".  Ok with that fix, thanks!
>
> -Chris
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Change-cmp_XY-x86-AVX-builtin-definition-in-avxintri.patch
Type: application/octet-stream
Size: 4520 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110330/bd4ec6c3/attachment.obj>