[cfe-commits] [PATCH] Re: [cfe-dev] Interest in a -Wusing-namespace-in-headers?

Douglas Gregor dgregor at apple.com
Fri Mar 18 09:15:12 PDT 2011

On Mar 17, 2011, at 11:05 AM, Elliot Glaysher (Chromium) wrote:

> Adds a -Wheader-hygiene warning for warnings that should only trigger
> in #included files.
> The first -Wheader-hygiene check is to make sure a using directive
> isn't placed in the global context in a header.
> On Wed, Mar 16, 2011 at 6:15 PM, Douglas Gregor <dgregor at apple.com> wrote:
>> You don't need to perform the getDiagnosticLevel() check yourself, because the diagnostic system will handle warning suppression itself.
>> However, I do suggest performing the CurContext->getDeclKind() == Decl::TranslationUnit check before the isFromMainFile() check, since the former is cheaper.
> Done.

Committed in r127881, thanks!

	- Doug

More information about the cfe-commits mailing list