[cfe-commits] [PATCH] Re-enabled and fixed fixit for main returning non-int

[Johannes Schaub (litb)]

Ryan Gerleve wrote:

> Hey everyone,
> I posted a patch for this to cfe-dev a while ago, before issue 8396
> (http://llvm.org/bugs/show_bug.cgi?id=8396) was closed, as my first
> clang hacking project (hence sending it to cfe-dev instead of
> cfe-commits). I thought it might be nice to have this fixit working
> again. An updated patch is attached, but it's in git format since I'm
> using the git mirror now. I hope that's OK :).
> 
> The problem was that BuiltinTypeLocs were only keeping track of a
> SourceLocation. I changed this to a SourceRange that expands to
> include all type specifiers. Also, width specifiers are now
> SourceRanges, in order to support 'long long'.
> 
> I welcome your feedback!

Is it up to handling type/decl specifiers intermixed?

  int extern long main() { }

Should replace "int extern long" by "int extern" or remove "long".