[cfe-commits] [PATCH]: -mrtd implementation

Douglas Gregor dgregor at apple.com
Tue Mar 1 09:23:41 PST 2011


On Mar 1, 2011, at 9:22 AM, Roman Divacky wrote:

> On Tue, Feb 22, 2011 at 10:42:16AM -0800, Douglas Gregor wrote:
>> 
>> On Feb 22, 2011, at 10:34 AM, Roman Divacky wrote:
>> 
>>> hi,
>>> 
>>> the attached patch implements -mrtd implementation. Ie. changing
>>> the default calling convention to stdcall.
>>> 
>>> Comments?
>> 
>> +def mrtd: Flag<"-mrtd">,
>> +  HelpText<"RTD call conv">;
>> 
>> This help text could be more helpful. What's RTD?
> 
> I changed it to "Make StdCall calling convention the default"
> 
>> Also, there are no tests?
> 
> test included now

Thanks, one last thing: please add serialization/deserialization of this LangOptions bit in the AST file (for PCH support).

	- Doug



More information about the cfe-commits mailing list