[cfe-commits] PATCH: Switch a tiny bit of the analyzer to use PresumedLoc

Chandler Carruth chandlerc at google.com
Tue Feb 22 18:11:20 PST 2011


And in a moment of brilliance I failed to attach the patch. Corrected. ;]

On Tue, Feb 22, 2011 at 6:09 PM, Chandler Carruth <chandlerc at google.com>wrote:

> I was trying to find and clean out uses of instantiated locations which
> actually wanted the presumed location that respects line tables etc for
> diagnostic output. I found this one in the static analyzer, and I think
> there were a couple of others in the HTMLDiagnostics, but haven't tracked
> all of them down yet. Look reasonable? Want me to switch others I find? (I'm
> checking that they're used for output to the user rather than other
> purposes.)
>
> As a related question, a lot of code in the analyzer uses source locations
> to check whether two locations are within the same file. Should these use
> presumed locations, and respect the file names taken from the #line table?
> If so, I'll work on that patch as well.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110222/8535d964/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use-presumed-loc1.patch
Type: application/octet-stream
Size: 1465 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110222/8535d964/attachment.obj>


More information about the cfe-commits mailing list