[cfe-commits] PATCH: Switch a tiny bit of the analyzer to use PresumedLoc

Chandler Carruth chandlerc at google.com
Tue Feb 22 18:09:52 PST 2011


I was trying to find and clean out uses of instantiated locations which
actually wanted the presumed location that respects line tables etc for
diagnostic output. I found this one in the static analyzer, and I think
there were a couple of others in the HTMLDiagnostics, but haven't tracked
all of them down yet. Look reasonable? Want me to switch others I find? (I'm
checking that they're used for output to the user rather than other
purposes.)

As a related question, a lot of code in the analyzer uses source locations
to check whether two locations are within the same file. Should these use
presumed locations, and respect the file names taken from the #line table?
If so, I'll work on that patch as well.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20110222/7c4c68bb/attachment.html>


More information about the cfe-commits mailing list