[cfe-commits] r124859 - in /cfe/trunk: test/Index/usrs.m tools/libclang/CIndexUSRs.cpp

[Ted Kremenek]

Author: kremenek
Date: Fri Feb  4 01:13:40 2011
New Revision: 124859

URL: http://llvm.org/viewvc/llvm-project?rev=124859&view=rev
Log:
USRs for Objective-C methods use the USR of the @interface as their base, not the USR of the class category or extension.

Modified:
    cfe/trunk/test/Index/usrs.m
    cfe/trunk/tools/libclang/CIndexUSRs.cpp

Modified: cfe/trunk/test/Index/usrs.m
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Index/usrs.m?rev=124859&r1=124858&r2=124859&view=diff
==============================================================================
--- cfe/trunk/test/Index/usrs.m (original)
+++ cfe/trunk/test/Index/usrs.m Fri Feb  4 01:13:40 2011
@@ -119,13 +119,13 @@
 // CHECK: usrs.m c:objc(ext)CWithExt at usrs.m@654 Extent=[57:1 - 59:5]
 // CHECK: usrs.m c:objc(cs)CWithExt(im)meth3 Extent=[58:1 - 58:14]
 // CHECK: usrs.m c:objc(cy)CWithExt at Bar Extent=[60:1 - 62:5]
-// CHECK: usrs.m c:objc(cy)CWithExt at Bar(im)meth4 Extent=[61:1 - 61:14]
+// CHECK: usrs.m c:objc(cs)CWithExt(im)meth4 Extent=[61:1 - 61:14]
 // CHECK: usrs.m c:objc(cs)CWithExt Extent=[63:1 - 67:2]
 // CHECK: usrs.m c:objc(cs)CWithExt(im)meth1 Extent=[64:1 - 64:27]
 // CHECK: usrs.m c:objc(cs)CWithExt(im)meth2 Extent=[65:1 - 65:27]
 // CHECK: usrs.m c:objc(cs)CWithExt(im)meth3 Extent=[66:1 - 66:27]
 // CHECK: usrs.m c:objc(cy)CWithExt at Bar Extent=[68:1 - 70:2]
-// CHECK: usrs.m c:objc(cy)CWithExt at Bar(im)meth4 Extent=[69:1 - 69:27]
+// CHECK: usrs.m c:objc(cs)CWithExt(im)meth4 Extent=[69:1 - 69:27]
 // CHECK: usrs.m c:@F at aux_1 Extent=[72:6 - 72:26]
 // CHECK: usrs.m c:@F at test_multi_declaration Extent=[73:5 - 77:2]
 // CHECK: usrs.m c:usrs.m at 980@F at test_multi_declaration@foo Extent=[74:3 - 74:14]

Modified: cfe/trunk/tools/libclang/CIndexUSRs.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/libclang/CIndexUSRs.cpp?rev=124859&r1=124858&r2=124859&view=diff
==============================================================================
--- cfe/trunk/tools/libclang/CIndexUSRs.cpp (original)
+++ cfe/trunk/tools/libclang/CIndexUSRs.cpp Fri Feb  4 01:13:40 2011
@@ -283,26 +283,14 @@
 }
 
 void USRGenerator::VisitObjCMethodDecl(ObjCMethodDecl *D) {
-  Decl *container = cast<Decl>(D->getDeclContext());
-  
-  // The USR for a method declared in a class extension is based on
+  // The USR for a method declared in a class extension or category is based on
   // the ObjCInterfaceDecl, not the ObjCCategoryDecl.
-  do {
-    if (ObjCCategoryDecl *CD = dyn_cast<ObjCCategoryDecl>(container))
-      if (CD->IsClassExtension()) {
-        // ID can be null with invalid code.
-        if (ObjCInterfaceDecl *ID = CD->getClassInterface()) {
-          Visit(ID);
-          break;
-        }
-        // Invalid code.  Can't generate USR.
-        IgnoreResults = true;
-        return;
-      }
-
-    Visit(container);
+  ObjCInterfaceDecl *ID = D->getClassInterface();
+  if (!ID) {
+    IgnoreResults = true;
+    return;
   }
-  while (false);
+  Visit(ID);
   
   // Ideally we would use 'GenObjCMethod', but this is such a hot path
   // for Objective-C code that we don't want to use