[cfe-commits] [PATCH] Win64 (esp. mingw64) stuff

Anton Korobeynikov anton at korobeynikov.info
Tue Jan 18 13:38:03 PST 2011

Hi Takumi,

> * 0005-lib-CodeGen-TargetInfo.cpp-Add-Win64-calling-con.patch.txt
>  Win64 calling conversion is quite different from AMD64 cc.
Looks ok for me with 2 minor things:

1. Comment in WinX86_64ABIInfo::computeInfo(CGFunctionInfo &FI) looks
confusing (it refers to AMD64 ABI)
2. Usually in llvm codebase the line breaks inside conditions look like:
if (a &&
    b || c)

So, ok for me with these 2 changes.

With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University

More information about the cfe-commits mailing list