[cfe-commits] r122781 - in /cfe/trunk: include/clang/Parse/Parser.h lib/Parse/ParseObjc.cpp lib/Parse/ParseStmt.cpp lib/Sema/SemaDecl.cpp test/Index/complete-synthesized.m

Chris Lattner clattner at apple.com
Mon Jan 3 18:04:37 PST 2011


On Jan 3, 2011, at 4:33 PM, Argyrios Kyrtzidis wrote:

>> 
>> Reasons why:
>> 
>> 1. This isn't a hot codepath, but this is more efficient because the call won't happen when not in code completion mode.
>> 2. "Maybe" as a prefix is bad because it doesn't mean anything :), and because it is capitalized.
>> 3. It's now really clear reading this in Parser that this has no impact when code completion is off.
> 
> Done in r122792.

Thanks!

> Though, for 2., note that 'maybe' as a prefix is used extensively.

I know :(  :(

-Chris



More information about the cfe-commits mailing list