[cfe-commits] [PATCH] Fix diagnostic reporting of previous default statement.

sashan sashan at zenskg.net
Mon Jan 3 03:09:09 PST 2011


On Mon Jan  3 00:33:53 2011, Douglas Gregor wrote:
> 
> On Dec 30, 2010, at 1:00 AM, sashan wrote:
> 
> > On Thu Dec 23 07:40:49 2010, Douglas Gregor wrote:
> >> 
> >> It's still not the right solution to look at the source locations. Just
> >> reverse the list and we'll have the cases in source order.
> >> 
> > 
> > Reversing the list was what I originally (see
> > http://lists.cs.uiuc.edu/pipermail/cfe-dev/2010-December/012387.html) did but it
> > doesn't work for this sort of statement:
> > 
> >  default:
> >  default:;
> 
> That seems like an easy fix?
>

Sorry but I'm not following. Currently, the default labels in that statement
above are inserted in source order and reversing the list un-orders it.  I can
think of a few ways to deal with a default/case label that has a another
default/case label as a sub-statement but none of them strike me as easy...




More information about the cfe-commits mailing list