[cfe-commits] r120088 - in /cfe/trunk: include/clang/AST/DeclBase.h include/clang/Driver/CC1Options.td include/clang/Frontend/ASTConsumers.h include/clang/Frontend/FrontendActions.h include/clang/Frontend/FrontendOptions.h lib/AST/CMakeLists.txt lib/Frontend/ASTConsumers.cpp lib/Frontend/CompilerInvocation.cpp lib/Frontend/FrontendActions.cpp lib/FrontendTool/ExecuteCompilerInvocation.cpp

[Chris Lattner]

>>> Currently just falls back on the StmtDumper to display statements,
>>> which means it doesn't produce valid XML in those cases.
>> 
>> I'm a bit dubious about this given the struggles we've had with the current XML dumper.  Please document somewhere that the output isn't guaranteed to be stable.
> 
> Can you elaborate on those struggles?  It seems to mostly be unmaintained.

Yes, it is unmaintained and yet there is great demand for it, so people keep trying to use it.

> I would like this to eventually replace -dump-ast, if we can agree on a syntax;  -dump-ast is nice for expressions, but useless for declarations.

How about you just remove -dump-ast and see if anyone cries? :)

> I am not wedded to XML, but there are much better visualization / exploration tools for XML than for not-really s-exprs. :)

Fair point :)  Are there any you'd recommend?

>> Also, why only in assert builds?  We have no precedent for that.
> 
> Since it's just a debugging tool, I didn't want to pay for the code size in release.  If you tell me not to sweat it, I won't. :)

Don't.  You can make up for it by zapping the other xml dumper :)

-Chris