[cfe-commits] r120066 - in /cfe/trunk: include/clang/Basic/FileManager.h lib/Basic/FileManager.cpp lib/Basic/FileSystemStatCache.cpp

[Chris Lattner]

Hi Francois,

I am away from svn for several days, if the patch has no clear fix, feel free to revert it.  Sorry for the breakage,

-Chris

On Nov 23, 2010, at 7:12 PM, Francois Pichet <pichet2000 at gmail.com> wrote:

> On Tue, Nov 23, 2010 at 5:32 PM, Chris Lattner <sabre at nondot.org> wrote:
>> Author: lattner
>> Date: Tue Nov 23 16:32:37 2010
>> New Revision: 120066
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=120066&view=rev
>> Log:
>> The final result of all this refactoring: instead of doing stat immediately
>> followed by an open for every source file we open, probe the file system with
>> 'open' and then do an fstat when it succeeds.  open+fstat is faster than
>> stat+open because the kernel only has to perform the string->inode mapping
>> once.  Presumably it gets faster the deeper in your filesystem a lookup
>> happens.
>> 
>> For -Eonly on cocoa.h, this reduces system time from 0.042s to 0.039s on
>> my machine, a 7.7% speedup.
>> 
>> 
>> Modified:
>>    cfe/trunk/include/clang/Basic/FileManager.h
>>    cfe/trunk/lib/Basic/FileManager.cpp
>>    cfe/trunk/lib/Basic/FileSystemStatCache.cpp
>> 
> 
> This caused some problems on Windows. see r120079.